Found new managed modules references #800
Conversation
![app-token-modules[bot]](https://avatars.githubusercontent.com/in/295926?s=60&v=4){kind=small}
app-token-modules
bot
requested review from
a team,
euforic and
unmultimedio
|
@jhump / @unmultimedio - Looks like v29.2 just came out, so what are the next steps to deprecate the existing gofeatures module? |
| shake256:95d1785a8277c3f6758e3f188e9432d820e93a99de99d1b45452ed2c8c8b1fecbef49efa8f553641d9bba716993420e255ddbc564d8796d1e480877f8c0c1aec google/protobuf/duration.proto | ||
| shake256:836c327709e30d7fcf6c35c8cff70c863130e3de6962b6337027f38513a672f1dc0496dd84538ee2c53994cc865fa3d68e0c4a87a4fc974601c7a6ebcdc05fe4 google/protobuf/empty.proto | ||
| shake256:d1706fd968269712822f6b51b3ffab303ccdd33c58b4d6c8414083a4fadb448bfd858d77088649165adfe9a08847f007611a3584718e63884e61f75c8bca7a5c google/protobuf/field_mask.proto | ||
| shake256:d264309578ef3aaedb99d74364b23d2d810a757671c4525dc95a42004ba3ddf4360a9cddddd5c5c51575a3db3b18d1e0ffc0d2d0daad7d38d60706536775d413 google/protobuf/go_features.proto |
I'd say we can merge this one, and send a PR either dropping the go features module (from both static/sync directories), or just comment it out from the For existing BSR instances, probably we'll need to send a migration marking it as deprecated. |
This seems right to me. We don't want to drop the old gofeatures module from any BSR instances, but we can stop sync'ing it and we want to update the README to indicate that it is deprecated and users should migrate to protobuf/wellknowntypes v29.2 or higher. Does changing the README in various BSR clusters require a migration? Is that a well-paved path? |
New managed modules references found. Please review.